-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
receiver/prometheus: roundtrip Prometheus->Pdata direct conversion without OpenCensus #3741
receiver/prometheus: roundtrip Prometheus->Pdata direct conversion without OpenCensus #3741
Conversation
73b5f3c
to
6cbd772
Compare
6cbd772
to
d9343be
Compare
Please rebase and fix conflicts. |
59fbe48
to
e4163c9
Compare
|
Thanks @bogdandrutu! Indeed, I should perhaps mark this PR as a draft because I have to translate the entire test suite, it's basically consumed most of my time for the past week. I'll actually mail small parts of it progressively. |
e4163c9
to
8ac86ff
Compare
This change wires together the logic to convert the pdata converters into a method ToMetricPdata that appends converted metrics. The next change or two, will then hook everything up directly and will allow us to delete all the prior code!! Updates #3137 Updates PR open-telemetry#3674 Requires PR open-telemetry#3694 Updates open-telemetry#3691
Wire up and use the direct Prometheus->Pdata conversion end to end. With this change the receiver will no longer need OpenCensus. This change will involve more follow-ups that just migrate over the tests, because we don't want a super bloated/massive PR. Fixes open-telemetry#3691 Depends on PR open-telemetry#3694 Depends on PR open-telemetry#3695
0a0d196
to
34e6396
Compare
f30e2ec
to
3cc2119
Compare
621a931
to
9c7274b
Compare
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
@odeke-em unfortunately this needs to be moved to contrib. Sorry and thanks :) |
Wire up and use the direct Prometheus->Pdata conversion end to end.
With this change the receiver will no longer need OpenCensus.
This change will involve more follow-ups that just migrate over the tests,
because we don't want a super bloated/massive PR.
Fixes #3691
Depends on PR #3694
Depends on PR #3695