Create new AWS ECS health check extension.

[skyduo]

Description:
This is a new health check extension feature for AWS/ECS, as we are going to monitor the OT collector health through the return status from endpoint of the new extension, detailed design in the design doc below, we will move this extension to opentelemetry-collector-contrib repo after we have can get the obsmetrics from internal folder in opentelemetry-collector.

Link to tracking Issue:
#2573

Testing:
make otelcol
./otelcol_darwin_amd64 --config /Users/tianduo/Documents/ot_healthcheck.yaml
run some script to connect to the endpoint, it will return 200/500 when the error number less/larger than the limit

Documentation:
https://docs.google.com/document/d/1SpUMsWA2DeaoVazeQ8uEc1Wvu5LphmQU_TjzLmuJ4QM/edit#heading=h.rs1luwizct2w

[linux-foundation-easycla]

• ❌ - skyduo The commit (dbf6854 ,46b5a8ce01ae667d670fc65f32e1011923d4f004 ,c5df49f2b4e589ca987f6f7daa2969e66204841e) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

[bogdandrutu]

Is this the only code that needs to access the internal package?

[skyduo]

@bogdandrutu yeah, i think this is the only thing we need to get from internal

[bogdandrutu]

Why not simply just adding to https://github.com/open-telemetry/opentelemetry-collector/blob/main/internal/obsreportconfig/obsmetrics/obs_exporter.go as a generic metric, then you don't need to do anything else.

[skyduo]

Hey @bogdandrutu ! i checked and found that i can add our new view here https://github.com/open-telemetry/opentelemetry-collector/blob/main/internal/obsreportconfig/obsreportconfig.go#L104-L105 due to we have to use view.Count(), so the code will be:

errorNumberView := &view.View{
		Name:        "ExporterFailedNumber",
		Description: "number of errors in exporters over span",
		Measure:     obsmetrics.ExporterFailedToSendSpans,
		Aggregation: view.Count(),
	}
views = append(views, errorNumberView)

is it correct? if so, i will push a new pr for this

[bogdandrutu]

Yes please

[bogdandrutu]

Why is this not enough? #3769?

[bogdandrutu]

You don't access that view anywhere else

[skyduo]

hey @bogdandrutu! so we have the new view in obsmetrics in the main repo and where is this metric sent to? we need to collect this new view in our new health check extension. We cannot even get the name of our new view now.

Our original code was:

if err := view.Register(&view.View{
		Name:        "AOC/ECSHealthCheckExporterFailedToSendSpans",
		Description: "number of errors in exporters over span",
		Measure:     obsmetrics.ExporterFailedToSendSpans,
		Aggregation: view.Count(),
	}); err != nil {
		log.Fatalf("Failed to register view: %v", err)
		return err
	}

	hc.exporter = newECSHealthCheckExporter()
	view.RegisterExporter(hc.exporter)
	return nil

so originally we used our view to register our new exporter, how can we do that in the new idea?

[bogdandrutu]

You don't use your view, you use the view package to register your exporter. See the fact that on line 44 you don't keep a reference on the view instance. You need to rely on the name in the exporter to access the data for this specific view.

[skyduo]

got it, i will push 2 new pr for the changes in opentelemetry-collector and opentelemetry-collector-contrib repo, thanks!

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 7 days.

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 7 days.