Bump Jaeger version to 1.14.0 (latest) #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Annanay <[email protected]>
annanay25
requested review from
bogdandrutu,
flands,
owais,
pjanotti,
songy23 and
tigrannajaryan
as code owners
Signed-off-by: Annanay <[email protected]>
|
I signed it |
Signed-off-by: Annanay <[email protected]>
songy23
reviewed
Sep 16, 2019
There was a problem hiding this comment.
goimports FAILED => fix the following goimports errors:
diff -u extension/healthcheckextension/healthcheckextension.go.orig extension/healthcheckextension/healthcheckextension.go
--- extension/healthcheckextension/healthcheckextension.go.orig 2019-09-14 20:34:39.697053255 +0000
+++ extension/healthcheckextension/healthcheckextension.go 2019-09-14 20:34:39.697053255 +0000
@@ -20,8 +20,9 @@
"strconv"
"github.com/jaegertracing/jaeger/pkg/healthcheck"
- "github.com/open-telemetry/opentelemetry-service/extension"
"go.uber.org/zap"
+
+ "github.com/open-telemetry/opentelemetry-service/extension"
)Please fix.
Signed-off-by: Annanay <[email protected]>
pjanotti
reviewed
Sep 17, 2019
There was a problem hiding this comment.
@annanay25 there are test failures because of the health extension changes:
--- FAIL: TestHealthCheckExtensionUsage (0.01s)
healthcheckextension_test.go:60:
Error Trace: healthcheckextension_test.go:60
Error: Not equal:
expected: 204
actual : 200
Test: TestHealthCheckExtensionUsage
--- FAIL: TestHealthCheckExtensionPortAlreadyInUse (0.00s)
healthcheckextension_test.go:94:
Error Trace: healthcheckextension_test.go:94
Error: Received unexpected error:
listen tcp :35499: bind: address already in use
Test: TestHealthCheckExtensionPortAlreadyInUse
--- FAIL: TestHealthCheckMultipleStarts (0.00s)
healthcheckextension_test.go:116:
Error Trace: healthcheckextension_test.go:116
Error: Received unexpected error:
listen tcp :35885: bind: address already in use
Test: TestHealthCheckMultipleStarts
FAIL
coverage: 87.5% of statements
FAIL github.com/open-telemetry/opentelemetry-service/extension/healthcheckextension 0.031s
and
--- FAIL: TestApplication_StartUnified (0.04s)
service_test.go:63: app didn't reach ready state
FAIL
coverage: 69.9% of statements
FAIL github.com/open-telemetry/opentelemetry-service/service 0.134s
Signed-off-by: Annanay <[email protected]>
|
@pjanotti - I've fixed all the healthcheck tests, not sure why |
songy23
reviewed
Sep 17, 2019
There was a problem hiding this comment.
I think you need to update https://github.com/open-telemetry/opentelemetry-service/pull/349/files#diff-469ef5f4321fa9af5e645d98ab1c5348R78:
return resp.StatusCode == http.StatusNoContent
->
return resp.StatusCode == http.StatusOK
Signed-off-by: Annanay <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #349 +/- ##
==========================================
- Coverage 74.4% 74.39% -0.01%
==========================================
Files 115 115
Lines 6708 6725 +17
==========================================
+ Hits 4991 5003 +12
- Misses 1470 1474 +4
- Partials 247 248 +1
Continue to review full report at Codecov.
|
songy23
approved these changes
Sep 18, 2019
|
Reviews, please have a look. |
owais
reviewed
Sep 19, 2019
pjanotti
suggested changes
Sep 19, 2019
There was a problem hiding this comment.
Hi @annanay25 - please, extract the common code between the two SubmitBatches implementation as suggested by @owais.
Signed-off-by: Annanay <[email protected]>
owais
reviewed
Sep 20, 2019
pjanotti
approved these changes
Sep 23, 2019
songy23
approved these changes
Sep 23, 2019
|
Thanks! |
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
…y#349) * Remove AddLink & Link from Span Interface I have remove AddLink and Link from the interface and all it refereneces and replaced AddLink with addlink, Also Removed respective unit tests Signed-off-by: vineeth <[email protected]> * removing the unused code from unit tests Signed-off-by: VineethReddy02 <[email protected]>
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Annanay [email protected]
Objective
Changes
cc @yurishkuro @jpkrohling