Remove usage of grpc-gateway in otlpreceiver. #3422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosalberto
approved these changes
Jun 11, 2021
jrcamp
approved these changes
Jun 11, 2021
rakyll
approved these changes
Jun 11, 2021
| } else { | ||
| msg, err = proto.Marshal(s.Proto()) | ||
| msg, err = proto.Marshal(rsp) |
There was a problem hiding this comment.
Shouldn't we log these errors?
| w.WriteHeader(statusCode) | ||
| w.Write(msg) // nolint:errcheck | ||
| // Nothing we can do with the error if we cannot write to the response. | ||
| _, _ = w.Write(msg) |
| } | ||
|
|
||
| // Pre-computed status with code=Internal to be used in case of a marshaling error. | ||
| var fallbackMsg = []byte(`{"code": 13, "message": "failed to marshal error message"}`) |
There was a problem hiding this comment.
Give a more self representative name such as marshalingErrorMsg = = []byte({"code": 13, "message": "failed to marshal error message"})
bogdandrutu
force-pushed
the
rmgrpcgateway
branch
from
2857006 to
cd1f10b
Compare
…erent than grpc Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
rmgrpcgateway
branch
from
cd1f10b to
f90ddc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Http protocols are different than grpc
Signed-off-by: Bogdan Drutu [email protected]