Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused testbed DataProvider from file #3388

Closed
wants to merge 1 commit into from
Closed

Remove unused testbed DataProvider from file #3388

wants to merge 1 commit into from

Conversation

bogdandrutu
Copy link
Member

Updates #3104

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested review from a team and jpkrohling June 8, 2021 14:25
@tigrannajaryan
Copy link
Member

FileDataProvider is used in TestMetricsFromFile. Why remove it? It is very useful for adding more tests that have pre-recorded in put data instead of using generators.

@bogdandrutu bogdandrutu mentioned this pull request Jun 9, 2021
Merged
@bogdandrutu
Copy link
Member Author

Closing this since I merged the alternative.

@bogdandrutu bogdandrutu deleted the rmunuseddataprovider branch July 25, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bogdandrutu @tigrannajaryan