Convert otlptext to implement Marshaler interfaces #3366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
textmarshaler
branch
from
8309ea2 to
1eed4ee
Compare
jpkrohling
reviewed
Jun 3, 2021
|
@jpkrohling see #3104 #3168 we want everything to work with pdata, and follow the same interfaces so we can have exporters that can log for example as text or json by just selecting the marshaler. |
carlosalberto
approved these changes
Jun 7, 2021
bogdandrutu
force-pushed
the
textmarshaler
branch
from
1eed4ee to
d8ae2d2
Compare
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
textmarshaler
branch
from
d8ae2d2 to
6c4bfd1
Compare
jrcamp
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu [email protected]