Port client side authentication interfaces from PR #3128 #3321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
approved these changes
May 27, 2021
|
That is correct @jpkrohling |
|
@bogdandrutu - Can you do a final review? |
|
Thanks @tigrannajaryan - updated the PR Just FYI, fixed the non existent link issue as well (AUTHOIDC has been renamed to OIDAUTH) |
tigrannajaryan
approved these changes
May 28, 2021
|
Thank you @pavankrish123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR ports the client authenticator interfaces from PR #3128 in a piece meal fashion. The interfaces are currently not used by any client configurations and are published for reviewing only.
Plan is to modify ToClient and ToDialOptions apis once all the clients are prepared per #3287 (core and contrib side as well).
Link to tracking Issue:
#3287 #3282
Testing:
Unit tests, manual test described (for only oidc)
Documentation:
Unit tests
cc: @jpkrohling @bogdandrutu @gramidt