Standarize Settings, Params and Parameters in Exporters #3164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
May 13, 2021
| @@ -33,19 +33,19 @@ func TestNewNopExporterFactory(t *testing.T) { | |||
| cfg := factory.CreateDefaultConfig() | |||
| assert.Equal(t, &nopExporterConfig{ExporterSettings: config.NewExporterSettings(config.NewID("nop"))}, cfg) | |||
|
|
|||
| traces, err := factory.CreateTracesExporter(context.Background(), component.ExporterCreateParams{}, cfg) | |||
| traces, err := factory.CreateTracesExporter(context.Background(), component.ComponentSettings{}, cfg) | |||
There was a problem hiding this comment.
Since this is used a lot in tests (lot's of time with zap.Nop), probably good to have in componenttest a NopComponentSettings or TestComponentSettings that uses zap.Nop + DefaultBuildInfo and pass that in tests.
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
pmatyjasek-sumo
force-pushed
the
pm_standarize_settings_exporters
branch
2 times, most recently
from
e48d8ab to
8006b6e
Compare
carlosalberto
approved these changes
May 24, 2021
|
Looks good to me, but needs to fix to apply @bogdandrutu's feedback, resolve conflicts and make sure the tests pass. |
bogdandrutu
approved these changes
May 26, 2021
|
Please rebase |
|
Also add a changelog entry |
pmatyjasek-sumo
force-pushed
the
pm_standarize_settings_exporters
branch
from
8006b6e to
31aebd6
Compare
pmatyjasek-sumo
force-pushed
the
pm_standarize_settings_exporters
branch
from
31aebd6 to
9677096
Compare
|
Please rebase the PR to fix merge conflicts |
Replace all dependencies in Exporters. Signed-off-by: Patryk Matyjasek <[email protected]> # Conflicts: # exporter/prometheusremotewriteexporter/factory.go # Conflicts: # exporter/fileexporter/factory.go # exporter/opencensusexporter/factory_test.go # exporter/otlpexporter/factory_test.go # exporter/prometheusremotewriteexporter/factory_test.go # Conflicts: # CHANGELOG.md # exporter/kafkaexporter/factory.go # exporter/opencensusexporter/factory.go # exporter/otlpexporter/factory.go # exporter/otlphttpexporter/factory.go # exporter/zipkinexporter/factory.go # Conflicts: # CHANGELOG.md # component/exporter.go # exporter/opencensusexporter/factory_test.go
pmatyjasek-sumo
force-pushed
the
pm_standarize_settings_exporters
branch
from
9677096 to
8e5a1a0
Compare
|
rebase done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Continuation work from #2991
Fixes #2650
Replace ExporterCreateParams with ExporterCreateSettings.
Replace all dependencies in Exporters.
Link to tracking Issue:
#2650
Testing:
Update unit tests
Documentation:
In code comments