Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the Prometheus remote write export #2987

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Simplify the Prometheus remote write export #2987

merged 1 commit into from
Apr 23, 2021

Conversation

rakyll
Copy link
Contributor

@rakyll rakyll commented Apr 22, 2021

No description provided.

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #2987 (0e7c6fb) into main (d10b842) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2987      +/-   ##
==========================================
+ Coverage   91.65%   91.66%   +0.01%     
==========================================
  Files         312      312              
  Lines       15427    15424       -3     
==========================================
- Hits        14139    14138       -1     
+ Misses        881      880       -1     
+ Partials      407      406       -1     
Impacted Files Coverage Δ
exporter/prometheusremotewriteexporter/exporter.go 90.47% <100.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d10b842...0e7c6fb. Read the comment docs.

@rakyll rakyll marked this pull request as ready for review April 22, 2021 06:10
@rakyll rakyll requested a review from a team April 22, 2021 06:10
@bogdandrutu bogdandrutu merged commit 3735180 into open-telemetry:main Apr 23, 2021
@rakyll rakyll deleted the prwexport branch April 23, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants