Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some unmarshaling errors to the Validate method #2929

Merged
merged 2 commits into from
Apr 14, 2021

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Apr 14, 2021

Description:

  • Move some errors happening during unmarshaling to the new Validate method.

Link to tracking Issue: #2867 (comment)

To be tracked on #2819

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #2929 (f705d9b) into main (fa73baf) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2929   +/-   ##
=======================================
  Coverage   91.66%   91.67%           
=======================================
  Files         312      312           
  Lines       15330    15334    +4     
=======================================
+ Hits        14053    14058    +5     
  Misses        870      870           
+ Partials      407      406    -1     
Impacted Files Coverage Δ
receiver/prometheusreceiver/config.go 66.66% <0.00%> (ø)
receiver/hostmetricsreceiver/config.go 58.33% <50.00%> (-5.31%) ⬇️
receiver/jaegerreceiver/config.go 100.00% <100.00%> (+8.82%) ⬆️
receiver/otlpreceiver/config.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa73baf...f705d9b. Read the comment docs.

@mx-psi mx-psi marked this pull request as ready for review April 14, 2021 16:33
@mx-psi mx-psi requested a review from a team April 14, 2021 16:33
@bogdandrutu bogdandrutu merged commit 671bf0a into open-telemetry:main Apr 14, 2021
@mx-psi mx-psi deleted the mx-psi/move-to-validate branch April 15, 2021 09:48
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants