Allow adding new signals in ProcessorFactory by forcing everyone to embed BaseProcessorFactory #2885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2885 +/- ##
=======================================
Coverage 91.77% 91.77%
=======================================
Files 286 287 +1
Lines 15088 15094 +6
=======================================
+ Hits 13847 13853 +6
Misses 849 849
Partials 392 392
Continue to review full report at Codecov.
|
bogdandrutu
force-pushed
the
hideextension
branch
from
d2d8c17 to
38d0f7c
Compare
…mbed BaseProcessorFactory Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
hideextension
branch
from
38d0f7c to
35e45ed
Compare
jrcamp
approved these changes
Apr 2, 2021
Co-authored-by: Jay Camp <[email protected]>
pjanotti
pushed a commit
to pjanotti/opentelemetry-service
that referenced
this pull request
Apr 6, 2021
…mbed BaseProcessorFactory (open-telemetry#2885) * Allow adding new signals in ProcessorFactory by forcing everyone to embed BaseProcessorFactory Signed-off-by: Bogdan Drutu <[email protected]> * Update component/processor.go Co-authored-by: Jay Camp <[email protected]> Co-authored-by: Jay Camp <[email protected]>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason to do this is to allow us to add factory methods for new signals in the future without breaking implementations.
Signed-off-by: Bogdan Drutu [email protected]