Add convenience interface in consumertest that implements all consumers

[bogdandrutu]

Signed-off-by: Bogdan Drutu [email protected]

[bogdandrutu]

/cc @Aneurysm9 @tigrannajaryan @jrcamp please let me know if you think this would help with usability.

[codecov]

Codecov Report

Merging #2878 (b348f3a) into main (4aeef52) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2878   +/-   ##
=======================================
  Coverage   91.76%   91.77%           
=======================================
  Files         286      286           
  Lines       15100    15104    +4     
=======================================
+ Hits        13857    13861    +4     
  Misses        850      850           
  Partials      393      393           

Impacted Files	Coverage Δ
component/componenttest/nop_exporter.go	100.00% <ø> (ø)
component/componenttest/nop_processor.go	100.00% <ø> (ø)
consumer/consumertest/err.go	100.00% <100.00%> (ø)
consumer/consumertest/nop.go	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aeef52...b348f3a. Read the comment docs.

[jrcamp]

I think it's an improvement.

[Aneurysm9]

I wonder whether it's worthwhile to combine the nopConsumer and errConsumer since the former seems to be identical to the latter with err == nil.

[bogdandrutu]

@Aneurysm9 is your suggestion to unify only the internal type of also the public API? If it is just the internal we can do it in a followup PR.

[bogdandrutu]

@Aneurysm9 please file an issue with this, I will move forward with the current approach since it is an improvement overall.