Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename [Start|End]Time to [Start|End]Timestamp in pdata #2847

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

bogdandrutu
Copy link
Member

Updates #2488

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested a review from a team March 30, 2021 01:03
@bogdandrutu
Copy link
Member Author

/cc @Aneurysm9

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #2847 (6f0aa2e) into main (c001a51) will not change coverage.
The diff coverage is 98.14%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2847   +/-   ##
=======================================
  Coverage   91.76%   91.76%           
=======================================
  Files         281      281           
  Lines       15145    15145           
=======================================
  Hits        13898    13898           
  Misses        853      853           
  Partials      394      394           
Impacted Files Coverage Δ
internal/version/version.go 80.00% <0.00%> (ø)
consumer/pdata/generated_metrics.go 100.00% <100.00%> (ø)
consumer/pdata/generated_trace.go 100.00% <100.00%> (ø)
exporter/loggingexporter/logging_exporter.go 96.40% <100.00%> (ø)
internal/goldendataset/metric_gen.go 100.00% <100.00%> (ø)
...eceiver/internal/scraper/cpuscraper/cpu_scraper.go 100.00% <100.00%> (ø)
...nternal/scraper/diskscraper/disk_scraper_others.go 100.00% <100.00%> (ø)
...internal/scraper/networkscraper/network_scraper.go 97.91% <100.00%> (ø)
...nal/scraper/pagingscraper/paging_scraper_others.go 100.00% <100.00%> (ø)
...internal/scraper/processscraper/process_scraper.go 98.14% <100.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c001a51...6f0aa2e. Read the comment docs.

@tigrannajaryan tigrannajaryan merged commit 0f17617 into open-telemetry:main Mar 31, 2021
@bogdandrutu bogdandrutu deleted the starttimestamp branch March 31, 2021 23:03
pjanotti pushed a commit to pjanotti/opentelemetry-service that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants