Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate metrics from memorylimiter #2841

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Mar 29, 2021

Same values are recorded as "processor/refused_spans"

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested a review from a team March 29, 2021 21:03
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #2841 (692d188) into main (4aeef52) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2841      +/-   ##
==========================================
- Coverage   91.76%   91.74%   -0.03%     
==========================================
  Files         286      285       -1     
  Lines       15100    15076      -24     
==========================================
- Hits        13857    13831      -26     
- Misses        850      851       +1     
- Partials      393      394       +1     
Impacted Files Coverage Δ
processor/memorylimiter/memorylimiter.go 90.00% <ø> (-0.36%) ⬇️
service/telemetry.go 85.18% <ø> (-0.27%) ⬇️
processor/batchprocessor/batch_processor.go 84.49% <100.00%> (ø)
processor/batchprocessor/metrics.go 100.00% <100.00%> (ø)
obsreport/obsreport.go 91.30% <0.00%> (-2.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aeef52...692d188. Read the comment docs.

@dmitryax
Copy link
Member

dmitryax commented Apr 1, 2021

Should we put it in the breaking changes list for the new version?

@bogdandrutu bogdandrutu merged commit a409f2a into open-telemetry:main Apr 2, 2021
@bogdandrutu bogdandrutu deleted the rmduplicatemetrics branch April 2, 2021 22:03
pjanotti pushed a commit to pjanotti/opentelemetry-service that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants