Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move configmodels to config #2808

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested a review from a team March 25, 2021 21:07
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #2808 (c983747) into main (acb3ae1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2808   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         290      290           
  Lines       15541    15541           
=======================================
  Hits        14242    14242           
  Misses        889      889           
  Partials      410      410           
Impacted Files Coverage Δ
component/componenttest/nop_host.go 100.00% <ø> (ø)
component/componenttest/shutdown_verifier.go 78.94% <ø> (ø)
config/config.go 100.00% <ø> (ø)
config/configtest/configtest.go 100.00% <ø> (ø)
config/exporter.go 100.00% <ø> (ø)
config/extension.go 100.00% <ø> (ø)
config/processor.go 100.00% <ø> (ø)
config/receiver.go 100.00% <ø> (ø)
exporter/exporterhelper/common.go 100.00% <ø> (ø)
exporter/exporterhelper/factory.go 100.00% <ø> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acb3ae1...c983747. Read the comment docs.

@tigrannajaryan
Copy link
Member

I am not sure why we need this change. configmodels appears to be a more specific and better name.

@bogdandrutu
Copy link
Member Author

It is the only package that we use 'models'. I am trying to be consistent with components, pdata, consumer, etc. Which don't use model in their package name

@bogdandrutu
Copy link
Member Author

I also need Parser in the same package with configmodels to allow having the custom unmarshaller on the config

Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants