Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move compatibility changes to internal, use when pdata parses traces from bytes #2798

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested a review from a team March 25, 2021 01:27
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #2798 (d3cc537) into main (c9f29e6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2798   +/-   ##
=======================================
  Coverage   91.71%   91.72%           
=======================================
  Files         293      293           
  Lines       15614    15616    +2     
=======================================
+ Hits        14321    14323    +2     
  Misses        887      887           
  Partials      406      406           
Impacted Files Coverage Δ
consumer/pdata/trace.go 100.00% <100.00%> (ø)
internal/otlp_wrapper.go 100.00% <100.00%> (ø)
receiver/otlpreceiver/trace/otlp.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9f29e6...d3cc537. Read the comment docs.

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@bogdandrutu bogdandrutu merged commit efe159c into open-telemetry:main Mar 25, 2021
@bogdandrutu bogdandrutu deleted the compchanges branch March 25, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants