move fluentbitextension to contrib #2795
Conversation
|
There are some links that are removed, see check-links |
|
@bogdandrutu I also see fluentbit mentions here and here should we drop it too or better wait for 2675? |
Codecov Report
@@ Coverage Diff @@
## main #2795 +/- ##
==========================================
- Coverage 91.71% 91.71% -0.01%
==========================================
Files 293 290 -3
Lines 15614 15506 -108
==========================================
- Hits 14321 14221 -100
+ Misses 887 882 -5
+ Partials 406 403 -3
Continue to review full report at Codecov.
|
|
Wait for the other one to clean |
|
Fluentbit seems to also be used in testbed https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-collector/6081/workflows/1143afd2-759f-481a-a61d-b969cbc5e1fe/jobs/70683 |
| @@ -24,7 +24,6 @@ import ( | |||
| ) | |||
|
|
|||
| func TestLog10kDPS(t *testing.T) { | |||
| flw := testbed.NewFluentBitFileLogWriter(testbed.DefaultHost, testbed.GetAvailablePort(t)) | |||
There was a problem hiding this comment.
We need to also remove testbed.NewFluentBitFileLogWriter and copy it to contrib correct?
There was a problem hiding this comment.
We need to also remove
testbed.NewFluentBitFileLogWriterand copy it to contrib correct?
See babd4e2 and open-telemetry/opentelemetry-collector-contrib@1365a25
There was a problem hiding this comment.
I am confused the code for NewFluentBitFileLogWriter is still in this repo:
https://github.com/open-telemetry/opentelemetry-collector/blob/main/testbed/testbed/senders.go#L628
And it is not removed.
There was a problem hiding this comment.
Ah, my apologies - I misread. Yes, testbed.NewFluentBitFileLogWriter will still need to be removed and copied to contrib - since I've already started moving the tests over in my PRs, I'll handle it there - I'll try to get those changes committed tomorrow AM and update here since it overlaps.
Note, this has been removed here babd4e2 |
|
@evkuzin on contrib I think you need to install fluentbit to pass the tests |
|
See #2723 (comment) |
…lemetry#2795) Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.26.1 to 0.26.3. - [Release notes](https://github.com/kubernetes/api/releases) - [Commits](kubernetes/api@v0.26.1...v0.26.3) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Description: Fluentbit Extension migration from the core to the contrib repo
Link to tracking Issue: 2674
Testing: whole fluent bit extension without changes was moved. All tests succeed locally