-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename [Traces|Metrics|Logs]Consumer to [Traces|Metrics|Logs] #2761
Conversation
/cc @Aneurysm9 |
Signed-off-by: Bogdan Drutu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2761 +/- ##
=======================================
Coverage 91.83% 91.83%
=======================================
Files 291 291
Lines 15522 15524 +2
=======================================
+ Hits 14254 14256 +2
Misses 867 867
Partials 401 401
Continue to review full report at Codecov.
|
@@ -593,7 +593,7 @@ func (pds *PrometheusDataSender) Start() error { | |||
return err | |||
} | |||
|
|||
pds.MetricsConsumer = exp | |||
pds.Metrics = exp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is worse than before. It is not clear what this Metrics
is since it is a very generic word. I do not mind renaming the type names but if we do that we must ensure embedded structs become fields so that they have a proper name otherwise readability of the code suffers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do agree that embedded fields are not best named in this situation, I would still do the change because it is more go standard way to name things like this. Do you mind if I look into this in a followup?
Co-authored-by: Tigran Najaryan <[email protected]>
Updates #2759
Signed-off-by: Bogdan Drutu [email protected]