Update demo app to build image #2760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2760 +/- ##
=======================================
Coverage 91.83% 91.83%
=======================================
Files 291 291
Lines 15522 15522
=======================================
Hits 14254 14254
Misses 867 867
Partials 401 401 Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Mar 22, 2021
Aneurysm9
changed the title
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Updated the demo metrics generator application to build a container image rather than using
go run main.goinside ago:1.12image. Also updated the metrics generator application to use ago:1.14image as Go 1.12 is no longer supported.Testing: Application was started with
docker-compose up -dand metrics were observed via the Prometheus container.