Ensure same time is used for updated time, and for expiration test #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2745 +/- ##
==========================================
- Coverage 91.67% 91.67% -0.01%
==========================================
Files 294 294
Lines 15640 15636 -4
==========================================
- Hits 14338 14334 -4
Misses 891 891
Partials 411 411
Continue to review full report at Codecov.
|
Ensure consistency, data points coming in the same batch are either all dropped or all exported. Signed-off-by: Bogdan Drutu <[email protected]>
tigrannajaryan
approved these changes
Mar 30, 2021
| n++ | ||
| continue | ||
| } | ||
| mv := v.(*accumulatedValue) | ||
|
|
||
| if ts.Before(mv.value.IntGauge().DataPoints().At(0).Timestamp().AsTime()) { | ||
| if ip.Timestamp().AsTime().Before(mv.value.IntGauge().DataPoints().At(0).Timestamp().AsTime()) { |
There was a problem hiding this comment.
Unrelated to your change: (mv.value.IntGauge().DataPoints().At(0).Timestamp().AsTime() doesn't look very safe. I wonder if any term here can be nil and cause a panic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure consistency, data points coming in the same batch are either all dropped or all exported.
Signed-off-by: Bogdan Drutu [email protected]