Sanitize prometheus labels #2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2707 +/- ##
=======================================
Coverage 91.81% 91.81%
=======================================
Files 290 290
Lines 15559 15559
=======================================
Hits 14285 14285
Misses 876 876
Partials 398 398
Continue to review full report at Codecov.
|
carlosalberto
approved these changes
Mar 16, 2021
This fixes open-telemetry#2700
bogdandrutu
approved these changes
Mar 18, 2021
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
) Signed-off-by: perhapsmaple <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2700
Description:
This fix allows the prometheus exporter to work with standard labels that follow the naming convention of using periods instead of underscores.
Link to tracking Issue:
#2700
Testing:
I will add tests in a second commit
Documentation:
No additional documentation added, is it worth mentioning?