Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the number of items from returned values in Push funcs #2684

Merged
merged 1 commit into from
Mar 13, 2021

Conversation

bogdandrutu
Copy link
Member

Even in code for metrics we did not have a consistent implementation,
also most important thing was not used anymore in observability helper.

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested a review from a team March 12, 2021 01:37
@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #2684 (60a1bb9) into main (407358b) will increase coverage by 0.00%.
The diff coverage is 77.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2684   +/-   ##
=======================================
  Coverage   91.80%   91.81%           
=======================================
  Files         290      290           
  Lines       15571    15559   -12     
=======================================
- Hits        14295    14285   -10     
+ Misses        878      876    -2     
  Partials      398      398           
Impacted Files Coverage Δ
exporter/exporterhelper/common.go 100.00% <ø> (ø)
exporter/zipkinexporter/zipkin.go 62.50% <16.66%> (ø)
exporter/otlpexporter/otlp.go 70.66% <55.55%> (-1.13%) ⬇️
exporter/loggingexporter/logging_exporter.go 96.40% <66.66%> (ø)
exporter/otlphttpexporter/otlp.go 83.52% <66.66%> (ø)
exporter/jaegerexporter/exporter.go 94.66% <75.00%> (-0.14%) ⬇️
exporter/opencensusexporter/opencensus.go 86.66% <75.00%> (-0.25%) ⬇️
exporter/exporterhelper/logshelper.go 100.00% <100.00%> (ø)
exporter/exporterhelper/metricshelper.go 100.00% <100.00%> (+5.71%) ⬆️
exporter/exporterhelper/queued_retry.go 97.72% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 407358b...60a1bb9. Read the comment docs.

@dmitryax
Copy link
Member

looks like rebase needed

Even in code for metrics we did not have a consistent implementation,
also most important thing was not used anymore in observability helper.

Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu
Copy link
Member Author

@dmitryax done

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@bogdandrutu bogdandrutu merged commit 03904de into open-telemetry:main Mar 13, 2021
@bogdandrutu bogdandrutu deleted the exphelperint branch March 13, 2021 01:25
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…emetry#2684)

Bumps [pytest-xdist](https://github.com/pytest-dev/pytest-xdist) from 3.2.0 to 3.2.1.
- [Release notes](https://github.com/pytest-dev/pytest-xdist/releases)
- [Changelog](https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst)
- [Commits](pytest-dev/pytest-xdist@v3.2.0...v3.2.1)

---
updated-dependencies:
- dependency-name: pytest-xdist
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants