Propogate name and transport for prometheus receiver and exporter

[yeya24]

Signed-off-by: yeya24 [email protected]

Description:
Fix the issue #2533 which the prometheus receiver and exporter names are not correctly propagated via the context.

Link to tracking Issue: #2533

Testing: < Describe what testing was performed and which tests were added.>
Only tested manually with the config below:

receivers:
  otlp:
    protocols:
      http:
  prometheus:
    config:
      scrape_configs:
        - job_name: "otel-collector"
          scrape_interval: 5s
          static_configs:
            - targets: ["localhost:8888"]
processors:
  batch:
extensions:
  health_check: {}
exporters:
  prometheusremotewrite:
    endpoint: "http://localhost:9090/api/v1/write"
    insecure: true
    external_labels:
      server: otel
  prometheus:
    endpoint: "0.0.0.0:8081"
    namespace: test-space
    const_labels:
      label1: value1
    send_timestamps: true
    metric_expiration: 180m
  logging:
    loglevel: debug
service:
  extensions: [health_check]
  pipelines:
    metrics:
      receivers: [otlp, prometheus]
      processors: [batch]
      exporters: [prometheusremotewrite, prometheus]

The metrics I can get from localhost:8888/metrics are

Documentation: < Describe the documentation added.>

Please delete paragraphs that you did not use before submitting.

[codecov]

Codecov Report

Merging #2680 (aed5e10) into main (b13bc9d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2680   +/-   ##
=======================================
  Coverage   91.73%   91.73%           
=======================================
  Files         290      290           
  Lines       15614    15615    +1     
=======================================
+ Hits        14324    14325    +1     
  Misses        892      892           
  Partials      398      398           

Impacted Files	Coverage Δ
receiver/prometheusreceiver/metrics_receiver.go	69.69% <100.00%> (+0.94%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b13bc9d...aed5e10. Read the comment docs.

[bogdandrutu]

@yeya24 thanks a lot, while reviewing this PR, I realize that our interface is error prone and went ahead and create #2682 which will remove the problems.

1. The fact that you need to call ExporterContext should not be the case.
2. You (and probably most will do the same) did not capture the context returned by startop which should be passed to endop.

I hope that PR solves your issue as well as improves usability. Can you check if that solves your issue?

[yeya24]

@bogdandrutu Thanks. Looks like your pr is a better way to solve that. The original interface is a little bit confusing.

You (and probably most will do the same) did not capture the context returned by startop which should be passed to endop.

Oops. I didn't even notice it returns a ctx.

[bogdandrutu]

@yeya24 I think we need to re-open this PR, since my PR only fixes the exporter and not the receiver part.

[bogdandrutu]

Can you remove the exporter fix and leave only the receiver part?

[yeya24]

Can you remove the exporter fix and leave only the receiver part?

Hi, I am happy to do that. Is the current receiver change okay or do I need to change anything?

One thing I am not very sure about is that I created a receiverCtx for the ocaStore. However, in each transaction, it calls https://github.com/open-telemetry/opentelemetry-collector/blob/main/receiver/prometheusreceiver/internal/transaction.go#L150. Is it better to put ReceiverCtx inside obsreport.StartMetricsReceiveOp?

[yeya24]

@bogdandrutu Hello, can you please take a look at this pr? Anything else I need to do to fix the failing test?

[bogdandrutu]

To fix the test just rerun that test

[yeya24]

@bogdandrutu Can you please take another review?
I have updated my pr and the failed test seems not related to my change.

[bogdandrutu]

This needs to start from context.Background() because the context from Start should not be stored and used later (not you bug, but please fix that as well).

[yeya24]

Sorry, I was going to update this but it was merged. Do you need me to open another pr?