Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ConfigValidate and add Validate on the Config struct #2665

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested a review from a team March 10, 2021 23:34
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #2665 (c608535) into main (2c017a0) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2665      +/-   ##
==========================================
- Coverage   91.75%   91.73%   -0.03%     
==========================================
  Files         289      290       +1     
  Lines       15655    15614      -41     
==========================================
- Hits        14365    14324      -41     
  Misses        892      892              
  Partials      398      398              
Impacted Files Coverage Δ
config/config.go 98.63% <ø> (-0.31%) ⬇️
config/configmodels/config.go 100.00% <100.00%> (ø)
config/configtest/configtest.go 100.00% <100.00%> (ø)
service/service.go 52.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c017a0...c608535. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 02a1fda into open-telemetry:main Mar 11, 2021
@bogdandrutu bogdandrutu deleted the rmcfgvalidate branch March 11, 2021 15:30
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…try#2665)

This is required for "multimod" tool utility to stop complaining
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants