testbed: Support UDP in addition to TCP for agent health check #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2633 +/- ##
=======================================
Coverage 91.77% 91.77%
=======================================
Files 281 281
Lines 15131 15131
=======================================
Hits 13886 13886
Misses 852 852
Partials 393 393 Continue to review full report at Codecov.
|
tigrannajaryan
approved these changes
Mar 16, 2021
tigrannajaryan
changed the title
bogdandrutu
reviewed
Mar 16, 2021
|
still have some strange ci test failed (markdown lint?) |
to support udp endpoint
wph95
force-pushed
the
add-testbd-check-udp-agent
branch
from
d28e0e0 to
4dd3ceb
Compare
|
Please rebase, will pass links tests |
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Testbed hardcode "tcp" in
agent_start/health_check. but I need add testbed add a syslog_input with "udp" testcase.so DataSender interface add a
GetNetworkProtocol() string, default is "tcp". makeagent_start/health_checksupport udpLink to tracking Issue: open-telemetry/opentelemetry-collector-contrib#2528