Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change testbed validator to use pdata #2561

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Change testbed validator to use pdata #2561

merged 1 commit into from
Apr 1, 2021

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Feb 26, 2021 •
edited
Loading

Added a TODO to fix the span links attributes and tracestate propagation when Jaeger is used.

Signed-off-by: Bogdan Drutu [email protected]

@codecov
Copy link

codecov bot commented Feb 26, 2021 •
edited
Loading

Codecov Report

Merging #2561 (6ba73a0) into main (a08a650) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2561   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files         286      286           
  Lines       15088    15088           
=======================================
  Hits        13847    13847           
  Misses        849      849           
  Partials      392      392

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a08a650...6ba73a0. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 6, 2021
@bogdandrutu bogdandrutu removed the Stale label Mar 6, 2021
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 14, 2021
@bogdandrutu bogdandrutu removed the Stale label Mar 14, 2021
@bogdandrutu bogdandrutu marked this pull request as ready for review March 14, 2021 20:34
@bogdandrutu bogdandrutu requested a review from a team March 14, 2021 20:34
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 22, 2021
@bogdandrutu bogdandrutu force-pushed the mvvalidator branch 2 times, most recently from 11e008c to 1d30446 Compare March 23, 2021 00:59
@bogdandrutu bogdandrutu removed the Stale label Mar 23, 2021
@bogdandrutu bogdandrutu force-pushed the mvvalidator branch 2 times, most recently from 5d829c6 to fa5e4bb Compare March 23, 2021 02:14
@tigrannajaryan
Copy link
Member

Correctness test failed.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 1, 2021
@bogdandrutu bogdandrutu removed the Stale label Apr 1, 2021
@bogdandrutu bogdandrutu force-pushed the mvvalidator branch 2 times, most recently from ad09f2f to 1f559e7 Compare April 1, 2021 15:49
@bogdandrutu
Change testbed validator to use pdata
6ba73a0 
Added a TODO to fix the span links attributes and tracestate propagation when Jaeger is used.

Signed-off-by: Bogdan Drutu <[email protected]>
dmitryax
dmitryax approved these changes Apr 1, 2021
View reviewed changes
testbed/testbed/validator.go
}

func NewCorrectTestValidator(provider DataProvider) *CorrectnessTestValidator {
func NewCorrectTestValidator(senderName string, receiverName string, provider DataProvider) *CorrectnessTestValidator {
// TODO: Fix Jaeger span links attributes and tracestate.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an issue for this? It's unclear why jaeger span links cannot be verified

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is because Jaeger does not propagate attributes for "references".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2879

@bogdandrutu bogdandrutu merged commit f16bb4c into open-telemetry:main Apr 1, 2021
@bogdandrutu bogdandrutu deleted the mvvalidator branch April 1, 2021 21:15
pjanotti pushed a commit to pjanotti/opentelemetry-service that referenced this pull request Apr 6, 2021
@bogdandrutu @pjanotti
Change testbed validator to use pdata (open-telemetry#2561)
9bf4fe2 
Added a TODO to fix the span links attributes and tracestate propagation when Jaeger is used.

Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bogdandrutu @tigrannajaryan @dmitryax