Fix OTLP receiver Shutdown() bug #2555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
changed the title
tigrannajaryan
force-pushed
the
feature/tigran/shutdown-otlp-receiver
branch
2 times, most recently
from
3163ee0 to
30ca26c
Compare
tigrannajaryan
changed the title
tigrannajaryan
force-pushed
the
feature/tigran/shutdown-otlp-receiver
branch
from
30ca26c to
96e9d25
Compare
Codecov Report
@@ Coverage Diff @@
## main #2555 +/- ##
==========================================
- Coverage 91.69% 91.64% -0.05%
==========================================
Files 267 268 +1
Lines 15107 15161 +54
==========================================
+ Hits 13852 13894 +42
- Misses 871 877 +6
- Partials 384 390 +6
Continue to review full report at Codecov.
|
OTLP receiver had a bug due to which it could generate data after Shutdown()
was returned.
It was visible in TestShutdown, with the following symptoms (it was a racy bug):
=== RUN TestShutdown
otlp_test.go:871:
Error Trace: otlp_test.go:871
Error: Not equal:
expected: 4
actual : 5
Test: TestShutdown
otlp_test.go:871:
Error Trace: otlp_test.go:871
Error: Not equal:
expected: 6
actual : 7
Test: TestShutdown
--- FAIL: TestShutdown (0.49s)
I added a Helper which allows to wait until all in-flight operations are complete
before the Shutdown() function returns.
The Helper can be used by other components too in the future.
tigrannajaryan
force-pushed
the
feature/tigran/shutdown-otlp-receiver
branch
from
96e9d25 to
1442692
Compare
|
I need a few pairs of fresh eye to verify the Helper implementation. |
bogdandrutu
reviewed
Feb 26, 2021
bogdandrutu
reviewed
Feb 27, 2021
| return errTimeout | ||
| case <-doneWaitingForProcessing: | ||
| } | ||
| return nil |
There was a problem hiding this comment.
This can be moved in the select
This is nice. I did not know there was already the graceful shutdown methods for servers. I will close this PR. |
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.9.0 to 0.9.1. - [Release notes](https://github.com/aquasecurity/trivy-action/releases) - [Commits](aquasecurity/trivy-action@0.9.0...0.9.1) --- updated-dependencies: - dependency-name: aquasecurity/trivy-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTLP receiver had a bug due to which it could generate data after Shutdown()
was returned.
It was visible in TestShutdown, with the following symptoms (it was a racy bug):
I added a Helper which allows to wait until all in-flight operations are complete
before the Shutdown() function returns.
The Helper can be used by other components too in the future.