Fix broken metrics exporting in the example #2381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pusher was missing in the metric controller creation. Due to this no metrics were exported at all. Added pusher similar to this example: https://github.com/open-telemetry/opentelemetry-go/blob/c066f15ed74fec52c4755014bfcf2bdfb8e0e661/example/otel-collector/main.go#L81 Tested with Collector and verified that now metrics are exported. Also renamed "pusher" to "cont" since it is not a Pusher but a Controller.
tigrannajaryan
commented
Jan 20, 2021
| processor.New( | ||
| simple.NewWithExactDistribution(), | ||
| exp, | ||
| ), | ||
| controller.WithCollectPeriod(7*time.Second), | ||
| controller.WithPusher(exp), |
There was a problem hiding this comment.
This line is the bug fix.
Codecov Report
@@ Coverage Diff @@
## master #2381 +/- ##
==========================================
+ Coverage 92.00% 92.02% +0.02%
==========================================
Files 272 272
Lines 15402 15402
==========================================
+ Hits 14170 14174 +4
+ Misses 850 847 -3
+ Partials 382 381 -1
Continue to review full report at Codecov.
|
carlosalberto
approved these changes
Jan 20, 2021
bogdandrutu
approved these changes
Jan 20, 2021
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pusher was missing in the metric controller creation. Due to this no metrics
were exported at all.
Added pusher similar to this example: https://github.com/open-telemetry/opentelemetry-go/blob/c066f15ed74fec52c4755014bfcf2bdfb8e0e661/example/otel-collector/main.go#L81
Tested with Collector and verified that now metrics are exported.
Also renamed "pusher" to "cont" since it is not a Pusher but a Controller.