Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change InstrumentationLibrary to be non-nullable #2196

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested a review from a team November 20, 2020 22:18
@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #2196 (23cba0d) into master (7874cd5) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2196      +/-   ##
==========================================
+ Coverage   91.98%   92.02%   +0.04%     
==========================================
  Files         271      271              
  Lines       15757    15733      -24     
==========================================
- Hits        14494    14479      -15     
+ Misses        860      853       -7     
+ Partials      403      401       -2     
Impacted Files Coverage Δ
consumer/pdata/generated_common.go 100.00% <ø> (ø)
consumer/pdata/generated_log.go 100.00% <ø> (ø)
consumer/pdata/generated_metrics.go 100.00% <ø> (ø)
consumer/pdata/generated_trace.go 100.00% <ø> (ø)
consumer/simple/metrics.go 98.87% <ø> (-0.01%) ⬇️
processor/filterprocessor/metric_index.go 100.00% <ø> (ø)
translator/trace/jaeger/jaegerproto_to_traces.go 90.81% <ø> (-0.05%) ⬇️
translator/trace/jaeger/traces_to_jaegerproto.go 90.11% <ø> (-0.08%) ⬇️
translator/trace/zipkin/traces_to_zipkinv2.go 93.71% <ø> (-0.07%) ⬇️
translator/trace/zipkin/zipkinv2_to_traces.go 90.00% <ø> (-0.04%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7874cd5...23cba0d. Read the comment docs.

@carlosalberto
Copy link
Contributor

(Symbolic approval - you guys may need to review your CODEOWNERS ;) )

@carlosalberto carlosalberto self-requested a review November 25, 2020 00:05
@bogdandrutu
Copy link
Member Author

@carlosalberto not sure I understand your comment

@bogdandrutu bogdandrutu merged commit 6049810 into open-telemetry:master Nov 25, 2020
@bogdandrutu bogdandrutu deleted the notnilil branch January 13, 2021 18:47
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
…#2196)

* Encode JSON objects to stdout one by one; not wrapped in lists

* Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants