Move scraper helpers to its own package scraperhelper #2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2185 +/- ##
==========================================
- Coverage 92.01% 91.99% -0.03%
==========================================
Files 270 270
Lines 15784 15756 -28
==========================================
- Hits 14524 14494 -30
- Misses 858 859 +1
- Partials 402 403 +1
Continue to review full report at Codecov.
|
james-bebbington
approved these changes
Nov 20, 2020
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
scraperhelper
branch
from
fdc8624 to
19d9090
Compare
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
open-telemetry#2185) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.39.1 to 1.40.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.39.1...v1.40.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…elemetry#2185) - setting partitions_auto_discovery_interval to 1 causes a storm of CommandPartitionedTopicMetadata requests to brokers. The broker doesn't log these requests and it's hard to detect the issue. The default value in the client is 1 minute which is 60*10^9. Set the example value to the default. - setting batching_max_publish_delay to 10 will make batching uneffective since the unit is nanoseconds. The default value in the client is 10 milliseconds which is 10^7. Set the example value to the default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #2036
Signed-off-by: Bogdan Drutu [email protected]