Remove the confusing package-level variable #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is unncessarily a package level variable and at the same time, the name is confusing. It should be called "empty" instead of dummy. But no need to have it as a package-level variable, hence this change removes it.
Codecov Report
@@ Coverage Diff @@
## master #2152 +/- ##
==========================================
+ Coverage 92.19% 92.20% +0.01%
==========================================
Files 280 280
Lines 16981 16981
==========================================
+ Hits 15655 15657 +2
+ Misses 908 907 -1
+ Partials 418 417 -1
Continue to review full report at Codecov.
|
|
Friendly ping. |
bogdandrutu
reviewed
Nov 17, 2020
| @@ -140,7 +138,7 @@ func (b *metricBuilder) AddDataPoint(ls labels.Labels, t int64, v float64) error | |||
| func (b *metricBuilder) Build() ([]*metricspb.Metric, int, int, error) { | |||
| if !b.hasData { | |||
| if b.hasInternalMetric { | |||
| return dummyMetrics, 0, 0, nil | |||
| return make([]*metricspb.Metric, 0), 0, 0, nil | |||
There was a problem hiding this comment.
Can this return nil instead of a slice with len 0?
There was a problem hiding this comment.
I'm not familiar enough with the semantics enough here to be confident returning nil and/or an error will be correct behavior. Leaving a TODO.
There was a problem hiding this comment.
I don't see the todo, did you forget to push the commit?
bogdandrutu
approved these changes
Nov 20, 2020
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is unncessarily a package level variable and at the same time, the name is confusing. It should be called "empty" instead of dummy. But no need to have it as a package-level variable, hence this change removes it.