Move tools to internal, create module to avoid dependency problems #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2131 +/- ##
==========================================
- Coverage 92.23% 92.02% -0.21%
==========================================
Files 280 270 -10
Lines 16977 15809 -1168
==========================================
- Hits 15658 14549 -1109
+ Misses 904 859 -45
+ Partials 415 401 -14
Continue to review full report at Codecov.
|
bogdandrutu
force-pushed
the
internaltools
branch
from
9090b52 to
740a2fe
Compare
tigrannajaryan
approved these changes
Nov 18, 2020
| @@ -15,6 +16,8 @@ ALL_PKGS := $(shell go list $(sort $(dir $(ALL_SRC)))) | |||
| ALL_DOC := $(shell find . \( -name "*.md" -o -name "*.yaml" \) \ | |||
| -type f | sort) | |||
|
|
|||
| TOOLS_MOD_DIR := ./internal/tools | |||
There was a problem hiding this comment.
Use TOOLS_MOD_DIR in line 4?
There was a problem hiding this comment.
A bit ugly to have "$(TOOLS_MOD_DIR)/*". Your call, we can do a separate PR.
This way we avoid dependency conflicts between tools and main codebase. Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
internaltools
branch
from
740a2fe to
eab8201
Compare
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
internaltools
branch
from
eab8201 to
de53e11
Compare
Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
internaltools
branch
from
9d33cca to
f1b5712
Compare
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
…#2131) * Fix Jaeger exporter agent port default value and docs * Update changelog * Revert example
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…#2131) Bumps [github.com/fsnotify/fsnotify](https://github.com/fsnotify/fsnotify) from 1.5.4 to 1.6.0. - [Release notes](https://github.com/fsnotify/fsnotify/releases) - [Changelog](https://github.com/fsnotify/fsnotify/blob/main/CHANGELOG.md) - [Commits](fsnotify/fsnotify@v1.5.4...v1.6.0) --- updated-dependencies: - dependency-name: github.com/fsnotify/fsnotify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we avoid dependency conflicts between tools and main codebase.
Signed-off-by: Bogdan Drutu [email protected]