Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where Prometheus SD config cannot be parsed #1877

Conversation

alvinlin123
Copy link
Contributor

Description:

Fixes issue #1867, the issue itself has background of the bug.

Testing:

  • I added unit tests to ensure all SD configs can be parsed.
  • I also tested by building an executable and ensure it can load sd configs.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 29, 2020

CLA Check
The committers are authorized under a signed CLA.

@alvinlin123 alvinlin123 reopened this Sep 29, 2020
@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #1877 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1877      +/-   ##
==========================================
- Coverage   91.29%   91.12%   -0.18%     
==========================================
  Files         273      263      -10     
  Lines       16365    16107     -258     
==========================================
- Hits        14940    14677     -263     
- Misses        998     1003       +5     
  Partials      427      427              
Impacted Files Coverage Δ
receiver/prometheusreceiver/factory.go 78.78% <ø> (ø)
...mplingprocessor/tailsamplingprocessor/processor.go 66.66% <0.00%> (-7.38%) ⬇️
config/config.go 96.09% <0.00%> (-2.79%) ⬇️
translator/internaldata/oc_to_metrics.go 91.97% <0.00%> (-0.41%) ⬇️
processor/metrics.go 71.76% <0.00%> (ø)
service/telemetry.go 81.96% <0.00%> (ø)
consumer/pdata/trace.go 100.00% <0.00%> (ø)
consumer/pdata/generated_log.go 100.00% <0.00%> (ø)
consumer/pdata/generated_trace.go 100.00% <0.00%> (ø)
processor/queuedprocessor/factory.go 100.00% <0.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1ac90b...b6e4120. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 2f703dc into open-telemetry:master Sep 29, 2020
@ocervell
Copy link

ocervell commented Oct 1, 2020

@bogdandrutu can we release a bug fix release for this ?
Currently we cannot use the Datadog exporter (introduced after the Prom receiver was broken) and Prometheus receiver at the same time ...

The latest version runs into this Prom bug, and the version before doesn't have the Datadog exporter implemented.

MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
* Unembed SpanContext

rebase branch

* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants