1/3 Add new perfcounters package that uses perflib #1835
Conversation
james-bebbington
requested review from
bogdandrutu,
dmitryax,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1835 +/- ##
=======================================
Coverage 91.12% 91.12%
=======================================
Files 263 263
Lines 16105 16105
=======================================
Hits 14675 14675
Misses 1003 1003
Partials 427 427 Continue to review full report at Codecov.
|
…arty / pdh package
james-bebbington
force-pushed
the
hostmetrics-perflib
branch
from
1f3715e to
30e1e18
Compare
| // MockPerfCounterScraperError returns the supplied errors when Scrape, GetObject, | ||
| // or GetValues are called. | ||
|
|
||
| type MockPerfCounterScraperError struct { |
There was a problem hiding this comment.
If this is for testing only and no reason to expose it publicly consider to:
Move it to a file that ends with _test.
Use lower case letter to not expose.
There was a problem hiding this comment.
If the intent is to keep it public add struct and funcs comments :)
There was a problem hiding this comment.
I do want to keep it public as the intent is for this Mock to be used by several different Scraper packages. Added a bunch of comments
Signed-off-by: Hu Shuai <[email protected]> Co-authored-by: Hu Shuai <[email protected]>
Link to tracking Issue: #973
Description:
1. Add new perflib package
2. Migrate host metrics scrapers to use new package
3. Remove third_party PDH code
See #1836 for example of usage