Rename Start() to Run() since it's a blocking call #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilebox
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
owais,
pjanotti and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1790 +/- ##
=======================================
Coverage 91.66% 91.66%
=======================================
Files 262 262
Lines 18603 18603
=======================================
Hits 17052 17052
Misses 1118 1118
Partials 433 433
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Sep 16, 2020
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Rename Start() to Run() to follow the naming pattern used in Go, e.g. see blocking Cmd.Run vs non-blocking Cmd.Start.
Revisiting #615
@tigrannajaryan @bogdandrutu This is a trivial breaking one-line change compared to many other breaking changes introduced in the recent releases and affecting every single custom component, so I think it's worth reconsidering the previous decision before GA.
Documentation: Included into CHANGELOG as a breaking change