-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log Support in Attribute Processor (1/2) #1783
Log Support in Attribute Processor (1/2) #1783
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1783 +/- ##
==========================================
- Coverage 91.29% 91.29% -0.01%
==========================================
Files 273 275 +2
Lines 16365 16431 +66
==========================================
+ Hits 14940 15000 +60
- Misses 998 1003 +5
- Partials 427 428 +1
Continue to review full report at Codecov.
|
Please consider to split the PR into smaller and easier to review PRs. It is ok if for a small period of time some code is not used. |
@keitwb is this ready for review or you plan to split the PR? |
The stuff in |
@keitwb |
@keitwb is this still the intent? |
Please fix the build. |
@keitwb The build is still failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… in thread-safe manner (open-telemetry#1783)
This complements the trace span support already present.
It shares the same config struct to maintain backwards-compatibility with spans in the cleanest way possible.