Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Support in Attribute Processor (1/2) #1783

Merged
merged 2 commits into from
Sep 30, 2020
Merged

Log Support in Attribute Processor (1/2) #1783

merged 2 commits into from
Sep 30, 2020

Conversation

keitwb
Copy link
Contributor

@keitwb keitwb commented Sep 14, 2020

This complements the trace span support already present.

It shares the same config struct to maintain backwards-compatibility with spans in the cleanest way possible.

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #1783 into master will decrease coverage by 0.00%.
The diff coverage is 88.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1783      +/-   ##
==========================================
- Coverage   91.29%   91.29%   -0.01%     
==========================================
  Files         273      275       +2     
  Lines       16365    16431      +66     
==========================================
+ Hits        14940    15000      +60     
- Misses        998     1003       +5     
- Partials      427      428       +1     
Impacted Files Coverage Δ
internal/data/testdata/log.go 98.13% <0.00%> (-1.87%) ⬇️
internal/processor/filterlog/filterlog.go 92.30% <92.30%> (ø)
internal/processor/filterconfig/config.go 100.00% <100.00%> (ø)
internal/processor/filterspan/filterspan.go 96.66% <100.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1ac90b...7fb2147. Read the comment docs.

@bogdandrutu
Copy link
Member

Please consider to split the PR into smaller and easier to review PRs. It is ok if for a small period of time some code is not used.

@tigrannajaryan
Copy link
Member

Please consider to split the PR into smaller and easier to review PRs. It is ok if for a small period of time some code is not used.

@keitwb is this ready for review or you plan to split the PR?

@tigrannajaryan tigrannajaryan self-assigned this Sep 17, 2020
@keitwb
Copy link
Contributor Author

keitwb commented Sep 17, 2020

Please consider to split the PR into smaller and easier to review PRs. It is ok if for a small period of time some code is not used.

@keitwb is this ready for review or you plan to split the PR?

The stuff in internal/processor can be reviewed now since that will be the dependency of the stuff in the actual processor. I will split all of the processor proper code out to another PR whose commit will be based on the internal/processor code in this PR.

@tigrannajaryan
Copy link
Member

@keitwb internal/processor changes look good to me. Please update the PR.

@tigrannajaryan
Copy link
Member

I will split all of the processor proper code out to another PR whose commit will be based on the internal/processor code in this PR.

@keitwb is this still the intent?

@keitwb keitwb changed the title Log Support for attribute Processor Log Support for attribute Processor (1/2) Sep 22, 2020
@keitwb keitwb changed the title Log Support for attribute Processor (1/2) Log Support in Attribute Processor (1/2) Sep 22, 2020
@tigrannajaryan
Copy link
Member

Please fix the build.

@tigrannajaryan
Copy link
Member

@keitwb The build is still failing.

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/processor/filterconfig/config.go Outdated Show resolved Hide resolved
@tigrannajaryan tigrannajaryan merged commit d8ca639 into open-telemetry:master Sep 30, 2020
@keitwb keitwb deleted the log-attribute-proc branch September 30, 2020 17:33
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants