Return a consumererror.permanent from componenterror.CombineErrors() when necessary #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huyan0
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1743 +/- ##
=======================================
Coverage 92.39% 92.39%
=======================================
Files 256 256
Lines 18190 18195 +5
=======================================
+ Hits 16806 16811 +5
Misses 970 970
Partials 414 414
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Sep 8, 2020
Comment on lines
+58
to
61
| if permanent { | ||
| return consumererror.Permanent(fmt.Errorf("[%s]", strings.Join(errMsgs, "; "))) | ||
| } | ||
| return fmt.Errorf("[%s]", strings.Join(errMsgs, "; ")) |
There was a problem hiding this comment.
err := fmt.Errorf("[%s]", strings.Join(errMsgs, "; "))
if permanent {
err = consumererror.Permanent(err)
}
return err
|
@anuraaga I think you have access to the org branch. Can you update this, it is an easy change. |
|
Merging this since the internship I think is done. I will fix the comment in a followup PR. |
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
Sep 11, 2020
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
added a commit
that referenced
this pull request
Sep 11, 2020
Signed-off-by: Bogdan Drutu <[email protected]>
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
…etry#1743) Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.38.0 to 1.39.0. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.38.0...v1.39.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tyler Yahn <[email protected]>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…y#1743) Bumps [boto3](https://github.com/boto/boto3) from 1.24.19 to 1.24.20. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.24.19...1.24.20) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
componenterror.CombineErrors()to return an error of typeconsumererror.permanentif any error passed to it is permanent. This PR also has some minor reformating of the testcases inerror_test.goto make the "{}" align and more readable.resolves #1736
cc @bogdandrutu