Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Processor: Logs Support (#1650) #1729

Merged
merged 2 commits into from
Sep 3, 2020

Conversation

pmm-sumo
Copy link
Contributor

@pmm-sumo pmm-sumo commented Sep 3, 2020

Description:

Adds logs support to Resource Processor

Link to tracking Issue: #1650

Testing: Unit test added as well as a simple manual test done (with fluentforward receiver and logging output)

Documentation: Added note on logs being supported

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #1729 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1729      +/-   ##
==========================================
+ Coverage   92.38%   92.40%   +0.01%     
==========================================
  Files         258      258              
  Lines       18201    18220      +19     
==========================================
+ Hits        16815    16836      +21     
+ Misses        972      971       -1     
+ Partials      414      413       -1     
Impacted Files Coverage Δ
processor/resourceprocessor/factory.go 100.00% <100.00%> (ø)
processor/resourceprocessor/resource_processor.go 100.00% <100.00%> (ø)
translator/internaldata/resource_to_oc.go 90.74% <0.00%> (ø)
receiver/otlpreceiver/otlp.go 94.44% <0.00%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95389af...f3458b4. Read the comment docs.

@pmm-sumo pmm-sumo force-pushed the resource-processor-logs branch from e188e50 to f3458b4 Compare September 3, 2020 14:36
@bogdandrutu bogdandrutu merged commit 315e96e into open-telemetry:master Sep 3, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
…test package (open-telemetry#1729)

* Remove setting error status while recording error

* Update CHANGELOG

Co-authored-by: Tyler Yahn <[email protected]>
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…telemetry#1729)

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.4 to 1.7.5.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.7.4...v1.7.5)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants