Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support to carry in the metrics pipeline for OC data #1726

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Sep 2, 2020

Split from #1720.

There are some changes that I had to do:

  • Remove LabelKey.Description which we don't propagate from OC to OTLP;
  • Some places where OC -> OTLP -> OC makes some empty slices to be nil (semantically no change, but when comparing protos this is a diff);
  • Some places we did not have MetricDescriptor; metrics without descriptor in OC are dropped.
  • Some node attributes are converted to Resource attributes (data are still present).

Updates #841

@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #1726 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1726      +/-   ##
==========================================
+ Coverage   92.36%   92.39%   +0.02%     
==========================================
  Files         259      259              
  Lines       18201    18163      -38     
==========================================
- Hits        16812    16781      -31     
+ Misses        976      970       -6     
+ Partials      413      412       -1     
Impacted Files Coverage Δ
consumer/pdatautil/pdatautil.go 81.48% <100.00%> (-11.17%) ⬇️
...eceiver/prometheusreceiver/internal/transaction.go 95.14% <100.00%> (+0.14%) ⬆️
processor/filterprocessor/filter_processor.go 90.47% <0.00%> (-4.77%) ⬇️
translator/internaldata/oc_to_metrics.go 94.39% <0.00%> (+1.40%) ⬆️
translator/internaldata/resource_to_oc.go 92.59% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af64ac9...3980307. Read the comment docs.

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very happy that we started cleaning this up.

consumer/pdatautil/pdatautil.go Show resolved Hide resolved
@bogdandrutu bogdandrutu merged commit 95389af into open-telemetry:master Sep 2, 2020
@bogdandrutu bogdandrutu deleted the splitrmdata branch September 2, 2020 23:28
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
* Remove links on NewRoot spans

To ensure forwards compatibility, remove the unspecified links currently
set on `NewRoot` spans.

Resolves open-telemetry#461

* Remove links from oteltest tracer to match
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…1726)

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.4 to 1.7.5.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.7.4...v1.7.5)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants