Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old metrics internal structs #1710

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

bogdandrutu
Copy link
Member

Fixes #1657

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #1710 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1710      +/-   ##
==========================================
- Coverage   92.33%   92.31%   -0.03%     
==========================================
  Files         265      259       -6     
  Lines       20061    18219    -1842     
==========================================
- Hits        18524    16818    -1706     
+ Misses       1109      988     -121     
+ Partials      428      413      -15     
Impacted Files Coverage Δ
consumer/pdatautil/pdatautil.go 92.64% <ø> (+8.55%) ⬆️
consumer/pdata/metric.go 87.73% <0.00%> (-5.67%) ⬇️
receiver/otlpreceiver/otlp.go 91.66% <0.00%> (-2.78%) ⬇️
translator/internaldata/resource_to_oc.go 88.88% <0.00%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82525f3...af9d603. Read the comment docs.

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bogdandrutu bogdandrutu merged commit 742c076 into open-telemetry:master Sep 1, 2020
@bogdandrutu bogdandrutu deleted the rmoldmetrics branch September 1, 2020 22:14
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
Update project version to v0.19.0
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to the new metrics proto
2 participants