Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors reported by gocritic and enable #1509

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

bogdandrutu
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #1509 into master will increase coverage by 0.03%.
The diff coverage is 62.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1509      +/-   ##
==========================================
+ Coverage   91.26%   91.29%   +0.03%     
==========================================
  Files         239      239              
  Lines       16685    16686       +1     
==========================================
+ Hits        15227    15233       +6     
  Misses       1047     1047              
+ Partials      411      406       -5     
Impacted Files Coverage Δ
exporter/otlpexporter/otlp.go 75.53% <0.00%> (+0.79%) ⬆️
processor/memorylimiter/memorylimiter.go 92.10% <0.00%> (+1.19%) ⬆️
processor/metrics.go 77.31% <33.33%> (+0.78%) ⬆️
receiver/fluentforwardreceiver/conversion.go 89.73% <50.00%> (+0.04%) ⬆️
exporter/opencensusexporter/factory.go 90.62% <75.00%> (+0.14%) ⬆️
...babilisticsamplerprocessor/probabilisticsampler.go 94.11% <100.00%> (ø)
receiver/prometheusreceiver/internal/logger.go 87.50% <100.00%> (ø)
...ceiver/prometheusreceiver/internal/metricfamily.go 98.98% <100.00%> (+<0.01%) ⬆️
...iver/prometheusreceiver/internal/metricsbuilder.go 100.00% <100.00%> (ø)
testutil/testutil.go 92.85% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b5122b...864a102. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 8a9d0fd into open-telemetry:master Aug 6, 2020
@bogdandrutu bogdandrutu deleted the gocritic branch August 6, 2020 16:49
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants