Optimize file system device filtering for simple case #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bebbington
requested review from
bogdandrutu,
dmitryax,
flands,
owais,
pjanotti,
rghetia and
tigrannajaryan
as code owners
james-bebbington
force-pushed
the
fs-device-filter-2
branch
from
d50b4e3 to
206dbad
Compare
bogdandrutu
approved these changes
Jul 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #1389 +/- ##
==========================================
+ Coverage 90.40% 90.44% +0.04%
==========================================
Files 218 218
Lines 15438 15443 +5
==========================================
+ Hits 13957 13968 +11
+ Misses 1070 1066 -4
+ Partials 411 409 -2
Continue to review full report at Codecov.
|
james-bebbington
force-pushed
the
fs-device-filter-2
branch
from
206dbad to
f2cdfa0
Compare
|
|
james-bebbington
force-pushed
the
fs-device-filter-2
branch
from
f2cdfa0 to
f9e6f63
Compare
Was testing metric count instead of data point count 🤦♂️ (happened to pass on Windows by chance) - fixed now :) |
james-bebbington
force-pushed
the
fs-device-filter-2
branch
3 times, most recently
from
84a2365 to
8b2ccb0
Compare
|
@james-bebbington still not fixed :) |
james-bebbington
force-pushed
the
fs-device-filter-2
branch
from
8b2ccb0 to
ce4765a
Compare
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.