Add support for queued retry in the exporter helper. #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
dmitryax,
flands,
james-bebbington,
owais,
pjanotti,
rghetia and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1386 +/- ##
==========================================
+ Coverage 90.51% 90.60% +0.08%
==========================================
Files 219 220 +1
Lines 15516 15674 +158
==========================================
+ Hits 14044 14201 +157
- Misses 1059 1060 +1
Partials 413 413
Continue to review full report at Codecov.
|
bogdandrutu
force-pushed
the
qretryexp
branch
4 times, most recently
from
69299f0 to
a72309d
Compare
Changed only the OTLP exporter for the moment to use the new settings. Timeout is enabled for all the exporters. Fixes open-telemetry#1193 There are some missing features that will be added in a followup PR: 1. Enforcing errors. For the moment added the Throttle error as a hack to keep backwards compatibility with OTLP. 2. Enable queued and retry for all exporters. 3. Fix observability metrics for the case when requests are dropped because the queue is full.
jpkrohling
reviewed
Jul 17, 2020
There was a problem hiding this comment.
Did an initial sweep, but haven't looked at the tests yet.
General comment: would it be possible to have a generic wrapping mechanism for senders? It would make it easier to understand the chain of senders, eventually leading to the timeoutSender, which calls request.export(ctx).
bogdandrutu
force-pushed
the
qretryexp
branch
3 times, most recently
from
6988081 to
a7ac75a
Compare
|
@tigrannajaryan @jpkrohling PTAL Thanks a lot for the review, I feel we are making progress :) |
bogdandrutu
force-pushed
the
qretryexp
branch
2 times, most recently
from
0828ede to
24860b5
Compare
bogdandrutu
force-pushed
the
qretryexp
branch
2 times, most recently
from
9d59924 to
6834dd6
Compare
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…y#1386) Bumps [boto3](https://github.com/boto/boto3) from 1.21.23 to 1.21.24. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.21.23...1.21.24) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Co-authored-by: Lalit Kumar Bhasin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed only the OTLP exporter for the moment to use the new settings.
Timeout is enabled for all the exporters. Fixes #1193
There are some missing features that will be added in a followup PR: