Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup qretry, do not backoff if no retries configured or failed to add to the queue #1311

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

bogdandrutu
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #1311 into master will increase coverage by 0.02%.
The diff coverage is 65.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1311      +/-   ##
==========================================
+ Coverage   89.34%   89.36%   +0.02%     
==========================================
  Files         212      212              
  Lines       15144    15126      -18     
==========================================
- Hits        13530    13517      -13     
+ Misses       1178     1174       -4     
+ Partials      436      435       -1     
Impacted Files Coverage Δ
consumer/consumererror/consumererror.go 77.77% <33.33%> (-22.23%) ⬇️
processor/queuedprocessor/queued_processor.go 76.37% <69.56%> (+2.90%) ⬆️
translator/internaldata/resource_to_oc.go 83.72% <0.00%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4272781...17d48a2. Read the comment docs.

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with minor comments.

processor/queuedprocessor/queued_processor.go Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu merged commit c30e815 into open-telemetry:master Jul 9, 2020
@bogdandrutu bogdandrutu deleted the qretry branch July 9, 2020 22:14
wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this pull request Jul 13, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
Remove cruft about spanStore.

Update documentation about how span.mu is used (related to open-telemetry#1311).

Reformat to conform with idiomatic field documentation.
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants