Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Context to the missing CreateMetricsReceiver method #1216

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

bogdandrutu
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 27, 2020

Codecov Report

Merging #1216 into master will not change coverage.
The diff coverage is 75.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1216   +/-   ##
=======================================
  Coverage   88.07%   88.07%           
=======================================
  Files         203      203           
  Lines       14658    14658           
=======================================
  Hits        12910    12910           
  Misses       1310     1310           
  Partials      438      438           
Impacted Files Coverage Δ
config/example_factories.go 87.80% <50.00%> (ø)
receiver/prometheusreceiver/factory.go 80.55% <50.00%> (ø)
service/builder/receivers_builder.go 73.98% <50.00%> (ø)
receiver/opencensusreceiver/factory.go 94.87% <100.00%> (ø)
receiver/vmmetricsreceiver/factory.go 81.81% <100.00%> (ø)
receiver/zipkinreceiver/factory.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b3d9c...9ff141c. Read the comment docs.

Copy link
Member

@james-bebbington james-bebbington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks fine to me, but it would be good to understand why we need to make this change, especially to the "old" interface.

@bogdandrutu
Copy link
Member Author

Even the old interfaces will be around for some time, and we want to make sure we have consistency

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update Contrib to use this change.

@bogdandrutu bogdandrutu merged commit 2f6d603 into open-telemetry:master Jun 29, 2020
@bogdandrutu bogdandrutu deleted the contextold branch June 29, 2020 22:22
wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this pull request Jul 13, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
* feat(span): remove SetAttribute method

* Update CHANGELOG.md

Revert markdown lint changes and unify the `Removed` section.

Co-authored-by: Tyler Yahn <[email protected]>
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
* Update core/contrib deps to v0.44.0

* Fix lint issues
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this pull request Oct 9, 2024
* remove

* polish

---------

Co-authored-by: Tyler Helmuth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants