-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Context to the missing CreateMetricsReceiver method #1216
Conversation
Signed-off-by: Bogdan Drutu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1216 +/- ##
=======================================
Coverage 88.07% 88.07%
=======================================
Files 203 203
Lines 14658 14658
=======================================
Hits 12910 12910
Misses 1310 1310
Partials 438 438
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change itself looks fine to me, but it would be good to understand why we need to make this change, especially to the "old" interface.
Even the old interfaces will be around for some time, and we want to make sure we have consistency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update Contrib to use this change.
…ry#1216) Signed-off-by: Bogdan Drutu <[email protected]>
* feat(span): remove SetAttribute method * Update CHANGELOG.md Revert markdown lint changes and unify the `Removed` section. Co-authored-by: Tyler Yahn <[email protected]>
* Update core/contrib deps to v0.44.0 * Fix lint issues
* remove * polish --------- Co-authored-by: Tyler Helmuth <[email protected]>
No description provided.