Do not embed ProtocolServerSettings in gRPC #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
dmitryax,
flands,
james-bebbington,
owais,
pjanotti,
rghetia and
tigrannajaryan
as code owners
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
grpcserverchange
branch
from
1c473fa to
c1e8a2f
Compare
Codecov Report
@@ Coverage Diff @@
## master #1210 +/- ##
==========================================
+ Coverage 87.62% 87.63% +0.01%
==========================================
Files 203 203
Lines 14676 14672 -4
==========================================
- Hits 12860 12858 -2
+ Misses 1375 1374 -1
+ Partials 441 440 -1
Continue to review full report at Codecov.
|
tigrannajaryan
approved these changes
Jun 26, 2020
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
Adding `ProtocolServerSettings` was a bit of a rush. We determined that `endpoint` has different meaning based on protocol, also not all the protocols support TLS. In this PR we revert embedding `ProtocolServerSettings` in the GRPCServerSettings and make it consistent with HttpServerSettings. Work left: Consistent config name for TLS settings `tls_settings` or `tls_credentials`.
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
ProtocolServerSettingswas a bit of a rush. We determined thatendpointhas different meaning based on protocol, also not all the protocols support TLS.In this PR we revert embedding
ProtocolServerSettingsin the GRPCServerSettings and make it consistent with HttpServerSettings.Work left: Consistent config name for TLS settings
tls_settingsortls_credentials.