-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Move exporterhelper queue code to exporterqueue #12033
Conversation
0fa36be
to
6765569
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12033 +/- ##
==========================================
- Coverage 91.67% 91.67% -0.01%
==========================================
Files 455 455
Lines 24033 24032 -1
==========================================
- Hits 22032 22031 -1
Misses 1629 1629
Partials 372 372 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Bogdan Drutu <[email protected]>
6765569
to
7d612f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a link/explanation on why we want to do this? This would increase the public API surface so I feel like we need to do some due diligence
Why? Everything is private types/funcs unless I missed something?
Not sure we need to explain that is better to have the implementation of the interfaces and the interface definition close to each other. Edit: Also, soon we need to extract "exporterqueue" so better to avoid circular dependencies between modules (even if possible, it is a sign of a bad design). |
Ah, looks like I got confused, sorry! LGTM then |
@mx-psi thank you |
d2c178b
…ry#12033) Signed-off-by: Bogdan Drutu <[email protected]>
No description provided.