Fixed untyped Prometheus receiver bug, updated tests and updated Design.md #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicolas-MacBeth
requested review from
bogdandrutu,
dmitryax,
flands,
james-bebbington,
owais,
pjanotti,
rghetia and
tigrannajaryan
as code owners
bogdandrutu
approved these changes
Jun 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #1194 +/- ##
=======================================
Coverage 87.56% 87.57%
=======================================
Files 203 203
Lines 14555 14562 +7
=======================================
+ Hits 12745 12752 +7
- Misses 1370 1371 +1
+ Partials 440 439 -1
Continue to review full report at Codecov.
|
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
…gn.md (open-telemetry#1194) * Fixed untyped Prometheus receiver bug, updated tests and updated Design.md * fixed a small comment
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Remove http status text * Updated changelog * More descriptive changelog Co-authored-by: Tyler Yahn <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this pull request
Oct 9, 2024
) * Enable external configmap checksum Fixes [collector] No collector reload when using external configmap open-telemetry#1194 * Update examples for `opentelemetry-collector` * Rename option to `configFile` for better consistency * Template checksum annotation for all Deployment modes * Add example for external configmap * Hint with option name that config is a chart Template * Remove unneeded example * Adhere to existing user-config convention * Update Collector chart schema to include new property * Regenerate Collector examples * Revert "Regenerate Collector examples" This reverts commit 5e6d8f885e46dc1e74ef2bd312c75d1e3c0fca89. * Remove configmap from local testing * Generate annotation checksums by inferring ConfigMap name from the value of `existingName` * Remove configmap from local testing * Run `make generate-examples CHARTS=opentelemetry-collector` * Bring back `configMap.existingPath` option There doesn't seem to be a way to get at rendered template contents in Helm. This key allows a user to specify the path to template file that will be used to create `configMap.existingName`, in cases like mine where we want to wrap this chart in a chart that feeds in custom configmap contents. * Regen examples to match upstream * Improve comments based on PR comments * Bump chart * Update examples for chart version `102.1` * Prefer `SHOULD` Co-authored-by: Tyler Helmuth <[email protected]> --------- Co-authored-by: Tyler Helmuth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Made
textparse.MetricTypeUnknownmetrics convert togaugeby default to fix a Prometheus Receiver bug whereuntypedmetrics were being dropped.Link to tracking Issue:
Issue link with much more details: #1103
Testing:
Modified the tests for the new type the metrics are being converted to.
Documentation:
Added a small line in the design documentation stating that we default
untypedmetrics togaugeThanks @asuresh4 and @bogdandrutu