Upgrade pdata to v1.5.0 #11932
Merged
Upgrade pdata to v1.5.0 #11932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11932 +/- ##
=======================================
Coverage 91.62% 91.62%
=======================================
Files 447 447
Lines 23729 23737 +8
=======================================
+ Hits 21741 21749 +8
Misses 1613 1613
Partials 375 375 ☔ View full report in Codecov by Sentry. |
dmathieu
commented
Dec 17, 2024
|
Unfortunately, due to a change in the way profile attributes are handled, this brings a breaking change to contrib, which isn't really fixable (we can read the data from the old method, but not write). I'd suggest a coordinated merge of the two PRs. |
dmathieu
requested review from
mx-psi,
a team,
bogdandrutu,
dmitryax and
andrzej-stencel
as code owners
rockdaboot
reviewed
Dec 17, 2024
dmathieu
force-pushed
the
upgrade-pdata
branch
from
f90033d to
2a2feff
Compare
Closed
mx-psi
approved these changes
Dec 20, 2024
Merged
via the queue into
open-telemetry:main
with commit Dec 20, 2024
e23802a
47 of 51 checks passed
codeboten
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Dec 21, 2024
#### Description This follows open-telemetry/opentelemetry-collector#11932, and upgrades pprofiletest with the breaking changes from the latest profile proto. --------- Signed-off-by: Alex Boten <[email protected]> Co-authored-by: Alex Boten <[email protected]>
AkhigbeEromo
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Jan 13, 2025
#### Description This follows open-telemetry/opentelemetry-collector#11932, and upgrades pprofiletest with the breaking changes from the latest profile proto. --------- Signed-off-by: Alex Boten <[email protected]> Co-authored-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proto 1.5.0 has been released. This upgrades pdata to use that version.
See https://github.com/open-telemetry/opentelemetry-proto/releases/tag/v1.5.0