Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] put back replace and add new packages in builder yaml #11909

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Dec 16, 2024

This reverts commit 5272797 because it breaks releases, see https://github.com/open-telemetry/opentelemetry-collector/actions/runs/12358329683/job/34488569900?pr=11904

and adds replace of the new x[consumer|experter|...] packages to the builder yaml

@songy23 songy23 added Skip Changelog PRs that do not require a CHANGELOG.md entry release Skip Contrib Tests labels Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.59%. Comparing base (00852e3) to head (e5b3b58).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11909   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files         449      449           
  Lines       23761    23761           
=======================================
  Hits        21763    21763           
  Misses       1623     1623           
  Partials      375      375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@songy23 songy23 changed the title [chore] add replace of new packages in builder yaml [chore] put back replace and add new packages in builder yaml Dec 16, 2024
@songy23 songy23 marked this pull request as ready for review December 16, 2024 19:27
@songy23 songy23 requested a review from a team as a code owner December 16, 2024 19:27
@songy23 songy23 requested a review from dmitryax December 16, 2024 19:27
@songy23 songy23 added the release:blocker The issue must be resolved before cutting the next release label Dec 16, 2024
@dmitryax dmitryax added this pull request to the merge queue Dec 16, 2024
Merged via the queue into open-telemetry:main with commit 96a3ad1 Dec 16, 2024
53 checks passed
@songy23 songy23 deleted the builder-test branch December 16, 2024 21:00
@github-actions github-actions bot added this to the next release milestone Dec 16, 2024
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:blocker The issue must be resolved before cutting the next release release Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants